Task/192 global exception handler#193
Closed
ntgbaoo wants to merge 3 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Member
Author
|
Risky but not worth. Closed for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Description
The current
GlobalExceptionHandlerdefines the theerror_codeandHttpStatusfor each exception. This is a bad design and not really scalable. Ideally, we should move these attributes to the exception classesRelated Issues: #193
Type of Change
Test Evidence
Describe how this PR has been tested.
Questions / Discussion Points
Important
For reviewers, since this PR is pretty important. Please check the error code and HTTP status for each Exception to make sure they match those defined in
GlobalExceptionHandler.